Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Commit

Permalink
Use different "good commit message" reference and inline it (#249)
Browse files Browse the repository at this point in the history
Signed-off-by: Eundoo Song <eundoo.song@gmail.com>
  • Loading branch information
eundoosong authored and yurishkuro committed Apr 18, 2018
1 parent 1608b0d commit e027317
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@ _Before making any significant changes, please [open an issue](https://github.co
Once we've discussed your changes and you've got your code ready, make sure that tests are passing (`npm test`) and open your pull request. Your pull request is most likely to be accepted if it:

* Includes tests for new functionality.
* Has a [good commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
* Has a [good commit message](https://chris.beams.io/posts/git-commit/):
* Separate subject from body with a blank line
* Limit the subject line to 50 characters
* Capitalize the subject line
* Do not end the subject line with a period
* Use the imperative mood in the subject line
* Wrap the body at 72 characters
* Use the body to explain _what_ and _why_ instead of _how_
* Each commit is signed by the author ([see below](#sign-your-work)).

## License and Certificate of Origin
Expand Down

0 comments on commit e027317

Please sign in to comment.