Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Allows to override codec's default baggage prefix. #310

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Allows to override codec's default baggage prefix. #310

merged 1 commit into from
Nov 5, 2018

Conversation

artemruts
Copy link
Contributor

Signed-off-by: Artem Ruts aruts@wayfair.com

Which problem is this PR solving?

Tracer can be configured to override codec's default TRACER_BAGGAGE_HEADER_PREFIX baggage prefix constant.

Short description of the changes

Passes baggagePrefix override from configuration.js initTracer's options to codec constructors in tracer.js

Signed-off-by: Artem Ruts <aruts@wayfair.com>
@artemruts artemruts changed the title Allowes to override codec's default baggage prefix. Allows to override codec's default baggage prefix. Nov 5, 2018
@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #310 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   98.93%   98.93%   +<.01%     
==========================================
  Files          43       43              
  Lines        1697     1698       +1     
  Branches      322      323       +1     
==========================================
+ Hits         1679     1680       +1     
  Misses         18       18
Impacted Files Coverage Δ
src/configuration.js 98.94% <ø> (ø) ⬆️
src/tracer.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1e1ff...553fac7. Read the comment docs.

@yurishkuro yurishkuro merged commit 7a9c100 into jaegertracing:master Nov 5, 2018
@yurishkuro
Copy link
Member

Thanks, @artemruts . Are you using Jaeger in your org? Please consider commenting on jaegertracing/jaeger#207.

Iuriy-Budnikov pushed a commit to agile-pm/jaeger-client-node that referenced this pull request Sep 25, 2021
* feat(metrics): add types and base implementation

* fix: styling

* Update packages/opentelemetry-metrics/src/export/types.ts

Make sum optional

* fix: make sum optional

* fix: use HrTime interface
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants