Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Add option to share the ids from the parent for rpc servers #399

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

jmoney
Copy link
Contributor

@jmoney jmoney commented Sep 18, 2019

Signed-off-by: Jonathan Monette jon.monette@gmail.com

Which problem is this PR solving?

Short description of the changes

Signed-off-by: Jonathan Monette <jon.monette@gmail.com>
@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #399 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #399      +/-   ##
=========================================
+ Coverage   98.65%   98.8%   +0.15%     
=========================================
  Files          50      50              
  Lines        2010    2013       +3     
  Branches      377     379       +2     
=========================================
+ Hits         1983    1989       +6     
+ Misses         27      24       -3
Impacted Files Coverage Δ
src/configuration.js 98.97% <ø> (ø) ⬆️
src/tracer.js 100% <100%> (ø) ⬆️
src/span_context.js 95.52% <0%> (+2.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9db520...2b37b33. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 127f21c into jaegertracing:master Sep 19, 2019
@jmoney jmoney deleted the jsm.shareRpcSpan branch September 19, 2019 23:01
Iuriy-Budnikov pushed a commit to agile-pm/jaeger-client-node that referenced this pull request Sep 25, 2021
)

* chore: add HTTPS to default instrumented plugins list

* fix: update node-sdk README
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parent and span IDs are not shared for rpc traces
2 participants