Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

Add toString to reporters #403

Merged
merged 1 commit into from
Sep 29, 2019

Conversation

Ithildir
Copy link
Contributor

Resolves #402

Signed-off-by: Andrea Di Giorgi andrea.digiorgi@joinhoney.com

Signed-off-by: Andrea Di Giorgi <andrea.digiorgi@joinhoney.com>
@codecov
Copy link

codecov bot commented Sep 27, 2019

Codecov Report

Merging #403 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage    98.8%   98.81%   +<.01%     
==========================================
  Files          50       50              
  Lines        2013     2023      +10     
  Branches      379      379              
==========================================
+ Hits         1989     1999      +10     
  Misses         24       24
Impacted Files Coverage Δ
src/reporters/in_memory_reporter.js 100% <100%> (ø) ⬆️
src/reporters/remote_reporter.js 95.74% <100%> (+0.18%) ⬆️
src/reporters/logging_reporter.js 100% <100%> (ø) ⬆️
src/reporters/noop_reporter.js 90% <100%> (+2.5%) ⬆️
src/reporters/composite_reporter.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e3b3a...3fbc60b. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yurishkuro yurishkuro merged commit 865ac99 into jaegertracing:master Sep 29, 2019
@Ithildir Ithildir deleted the reporters-tostring branch October 3, 2019 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialization log message does not show resolver name
2 participants