Fix env parsing of falsy values (#460)

[Gerrit-K]

Signed-off-by: Gerrit Kieffer kieffer.gerrit@gmail.com

Which problem is this PR solving?

• Resolves ConfigurationEnv doesn't allow falsy values #460

Short description of the changes

• This is a re-issue of Fix env parsing of falsy values (#460) #461 (due to an incorrect source branch)
• Replace implicit boolean evaluation with explicit check in ternary operator / number check

[yurishkuro]

Thanks

[codecov]

Codecov Report

Merging #462 (0138992) into master (6a6e3ea) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          50       50           
  Lines        2035     2035           
  Branches      383      383           
=======================================
  Hits         2009     2009           
  Misses         26       26           

Impacted Files	Coverage Δ
src/configuration_env.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6e3ea...0138992. Read the comment docs.

[Gerrit-K]

Hm, as in the previous PR, crossdock and the node 4 tests fail, but I don't see any relation to my changes :/

For crossdock it seems that it's timing out waiting for a service:

2021/04/24 16:44:42 HTTP: HEAD http://node:8080/
2021/04/24 16:44:42 HTTP: Service node:8080 timed out. Last error: Head http://node:8080/: dial tcp 172.18.0.5:8080: getsockopt: connection refused
2021/04/24 16:44:42 Error: One or more services timed out after 4m0s
1
make: *** [crossdock/rules.mk:17: crossdock-fresh] Error 1
Error: Process completed with exit code 2.

For the node 4 tests it looks like a dependency issue to me, but I don't really know:

/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/tchannel/node_modules/run-parallel/index.js:7
  let results, pending, keys
  ^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:373:25)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/tchannel/out_request.js:29:16)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/tchannel/v2/out_request.js:25:18)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/tchannel/v2/handler.js:34:18)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/tchannel/v2/index.js:112:26)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/tchannel/connection.js:33:10)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/tchannel/channel.js:63:26)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/home/runner/work/jaeger-client-node/jaeger-client-node/dist/test/tchannel_bridge.js:41:17)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at /home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/mocha/lib/mocha.js:231:27
    at Array.forEach (native)
    at Mocha.loadFiles (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/mocha/lib/mocha.js:228:14)
    at Mocha.run (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/mocha/lib/mocha.js:514:10)
    at Object.<anonymous> (/home/runner/work/jaeger-client-node/jaeger-client-node/node_modules/mocha/bin/_mocha:480:18)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Function.Module.runMain (module.js:441:10)
    at startup (node.js:140:18)
    at node.js:1043:3

npm ERR! Linux 5.4.0-1046-azure
npm ERR! argv "/opt/hostedtoolcache/node/4.9.1/x64/bin/node" "/opt/hostedtoolcache/node/4.9.1/x64/bin/npm" "run" "test-dist"
npm ERR! node v4.9.1
npm ERR! npm  v2.15.11
npm ERR! code ELIFECYCLE
npm ERR! jaeger-client@3.18.2-dev test-dist: `mocha dist/test/ dist/test/baggage/ dist/test/throttler/ dist/test/samplers/ dist/test/metrics/`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the jaeger-client@3.18.2-dev test-dist script 'mocha dist/test/ dist/test/baggage/ dist/test/throttler/ dist/test/samplers/ dist/test/metrics/'.
npm ERR! This is most likely a problem with the jaeger-client package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     mocha dist/test/ dist/test/baggage/ dist/test/throttler/ dist/test/samplers/ dist/test/metrics/
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs jaeger-client
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! 
npm ERR!     npm owner ls jaeger-client
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/runner/work/jaeger-client-node/jaeger-client-node/npm-debug.log
make: *** [Makefile:29: test-without-build] Error 1
Error: Process completed with exit code 2.

[yurishkuro]

I am fixing CI in #463