-
Notifications
You must be signed in to change notification settings - Fork 155
Conversation
Fixing the issues found in integration. edit: Issues resolved. |
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 94.75% 95.06% +0.31%
==========================================
Files 25 26 +1
Lines 1773 1926 +153
Branches 224 256 +32
==========================================
+ Hits 1680 1831 +151
+ Misses 60 54 -6
- Partials 33 41 +8
Continue to review full report at Codecov.
|
Expands span reporter selection by breaking out Reporter into base QueueReporter class and using reporting method-specific ThriftReporter and ZipkinV2Reporter. Also breaks LocalAgentSender into two classes including LocalAgentReader for ThriftReporter only usage of TBufferedTransport. These changes allow users to continue reporting spans oob to the local jaeger-agent but with the option of reporting to Zipkin backend. In the spirit of jaegertracing/jaeger-client-java#399 and jaegertracing/jaeger-client-go#310 Signed-off-by: Ryan Fitzpatrick <rmfitzpatrick@signalfx.com>
471709b
to
b3b5226
Compare
Signed-off-by: Ryan Fitzpatrick <rmfitzpatrick@signalfx.com>
I've increased test coverage for all proposed changes, including some potentially overreaching reporter tests. Apologies for the churn and any feedback would be greatly appreciated. |
@black-adder and @yurishkuro, in light of jaegertracing/jaeger#925 understandably preventing these changes from being accepted, if a short term requirement is a thrift over http reporter in the client do you think it's reasonable for me to:
|
@rmfitzpatrick I think that'd be great. |
Expands span reporter selection by breaking out Reporter into base
QueueReporter class and using reporting method-specific ThriftReporter
and ZipkinV2Reporter. Also breaks LocalAgentSender into two classes
including LocalAgentReader for ThriftReporter only usage of
TBufferedTransport.
These changes allow users to continue reporting spans oob to the local
jaeger-agent but with the option of reporting to Zipkin backend.
In the spirit of
jaegertracing/jaeger-client-java#399
and
jaegertracing/jaeger-client-go#310
Signed-off-by: Ryan Fitzpatrick rmfitzpatrick@signalfx.com