Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar exposes all ports as TCP, but some are expected to be UDP #771

Closed
garyfritz opened this issue Nov 15, 2019 · 1 comment
Closed

Comments

@garyfritz
Copy link
Contributor

garyfritz commented Nov 15, 2019

Analogous to #577, when injecting agent containers, the container ports of injected sidecar containers are exposed as TCP, but three out of four should be UDP.

This is from an agent pod from a daemon set (which is correct according to #577):

  jaeger-agent-daemonset:
    Image:         jaegertracing/jaeger-agent:1.15.0
    Ports:         5775/UDP, 5778/TCP, 6831/UDP, 6832/UDP, 14271/TCP
    Host Ports:    5775/UDP, 5778/TCP, 6831/UDP, 6832/UDP, 14271/TCP
    Args:
      --reporter.grpc.host-port=dns:///izjaeger-collector-headless.default:14250
      --reporter.type=grpc

While this is from an injected agent container in some of my pods:

  jaeger-agent:
    Image:         jaegertracing/jaeger-agent:1.15.0
    Ports:         5775/TCP, 5778/TCP, 6831/TCP, 6832/TCP
    Host Ports:    0/TCP, 0/TCP, 0/TCP, 0/TCP
    Args:
      --reporter.grpc.host-port=dns:///izjaeger-collector-headless.default:14250
      --reporter.type=grpc

I'd suggest adding the missing protocol specifications to

Ports: []corev1.ContainerPort{
{
ContainerPort: zkCompactTrft,
Name: "zk-compact-trft",
},
{
ContainerPort: configRest,
Name: "config-rest",
},
{
ContainerPort: jgCompactTrft,
Name: "jg-compact-trft",
},
{
ContainerPort: jgBinaryTrft,
Name: "jg-binary-trft",
},
},

garyfritz pushed a commit to garyfritz/jaeger-operator that referenced this issue Nov 15, 2019
garyfritz pushed a commit to garyfritz/jaeger-operator that referenced this issue Nov 15, 2019
…ed sidcar containers

Signed-off-by: Gary Fritz <fritz@iz.de>
garyfritz pushed a commit to garyfritz/jaeger-operator that referenced this issue Nov 18, 2019
…ed sidcar containers

Signed-off-by: Gary Fritz <fritz@iz.de>
@garyfritz
Copy link
Contributor Author

Closing since MR #773 is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant