Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger tags for injected agent are only added if a single container is present #863

Closed
TBBle opened this issue Jan 19, 2020 · 2 comments · Fixed by #864
Closed

Jaeger tags for injected agent are only added if a single container is present #863

TBBle opened this issue Jan 19, 2020 · 2 comments · Fixed by #864
Labels
bug Something isn't working

Comments

@TBBle
Copy link
Contributor

TBBle commented Jan 19, 2020

I'm specifically looking at func container in https://github.com/jaegertracing/jaeger-operator/blob/master/pkg/inject/sidecar.go.

The flow appears to be intended to inject a bunch of tags from the pod info, and if a single container is present, include a tag about the container.

However, the entire set of tags is only added in a single-container setup.

This looks like a trivial mistake in #648.

@ghost ghost added the needs-triage New issues, in need of classification label Jan 19, 2020
@TBBle
Copy link
Contributor Author

TBBle commented Jan 19, 2020

I don't have an immediate fix for it, but I suspect the 'only one container' logic will also fail if called from UpdateSidecar, as it the jaeger-agent side-car will be seen as a second container.

@objectiser objectiser added bug Something isn't working and removed needs-triage New issues, in need of classification labels Jan 20, 2020
@jpkrohling
Copy link
Contributor

Nice catch!

jpkrohling pushed a commit that referenced this issue Jan 28, 2020
Fixes: #863

Signed-off-by: Paul "Hampy" Hampson <p_hampson@wargaming.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants