Avoid calling k8s api for each resource kind on the cluster #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
rubenvp8510
force-pushed
the
Issue-1684
branch
from
aee96ae
to
e8fbb16
Compare
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
+ Coverage 87.71% 87.74% +0.02%
==========================================
Files 98 98
Lines 5958 5972 +14
==========================================
+ Hits 5226 5240 +14
Misses 556 556
Partials 176 176
Continue to review full report at Codecov.
|
pavolloffay
reviewed
Jan 19, 2022
pkg/autodetect/main.go
Outdated
| @@ -109,8 +111,29 @@ func (b *Background) autoDetectCapabilities() { | |||
| b.cleanDeployments(ctx) | |||
| } | |||
|
|
|||
| func (b *Background) isInListenedGroups(group *metav1.APIGroup) bool { | |||
| for _, groupName := range groupsListened { | |||
There was a problem hiding this comment.
map might be more efficient here. The code checks if a given group should be handled or not.
pkg/autodetect/main.go
Outdated
| @@ -109,8 +111,29 @@ func (b *Background) autoDetectCapabilities() { | |||
| b.cleanDeployments(ctx) | |||
| } | |||
|
|
|||
| func (b *Background) isInListenedGroups(group *metav1.APIGroup) bool { | |||
There was a problem hiding this comment.
passing group by value seems better here
pkg/autodetect/main.go
Outdated
| if b.isInListenedGroups(&sg) { | ||
| groupAPIList, err := b.dcl.ServerResourcesForGroupVersion(sg.PreferredVersion.GroupVersion) | ||
| if err != nil { | ||
| return apiLists, err |
There was a problem hiding this comment.
I would either return empty apiList or accumulate errors and return the error with gathered groups once all calls are done.
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
pavolloffay
reviewed
Jan 19, 2022
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
pavolloffay
previously approved these changes
Jan 19, 2022
Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ruben Vargas ruben.vp8510@gmail.com
Which problem is this PR solving?
PreferedServerResourcesdoes a lot of calls to the API when the cluster has a lot of different resource Kinds.Short description of the changes
ServerGroupsand then only get the resources for our interested Groups.Note: I still see one line in the log with the error "Waited Xs.." but one single time, I don't see the same error repeating in logs each N seconds. so I think this can be considered a fix.