Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added flag to change webhook port #1991

Merged
merged 2 commits into from
Jul 11, 2022
Merged

added flag to change webhook port #1991

merged 2 commits into from
Jul 11, 2022

Conversation

klubi
Copy link
Contributor

@klubi klubi commented Jul 11, 2022

Signed-off-by: Piotr Klubinski piotr.klubinski@jamf.com

Which problem is this PR solving?

Resolves #1963

Short description of the changes

Will expose new flag, that allows to change port on which webhooks are exposed.

@frzifus frzifus self-requested a review July 11, 2022 09:24
Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome :)

@frzifus frzifus enabled auto-merge (squash) July 11, 2022 09:25
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1991 (b78b41a) into main (9f4a8d2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1991   +/-   ##
=======================================
  Coverage   88.24%   88.24%           
=======================================
  Files         100      100           
  Lines        6387     6387           
=======================================
  Hits         5636     5636           
  Misses        553      553           
  Partials      198      198           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4a8d2...b78b41a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't deploy Jaeger on AWS EKS using Calico
2 participants