Fix query ingress when using streaming strategy #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <kearls@redhat.com>
frzifus
previously approved these changes
Nov 16, 2022
Codecov ReportBase: 87.32% // Head: 87.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2120 +/- ##
=======================================
Coverage 87.32% 87.33%
=======================================
Files 100 100
Lines 6865 6867 +2
=======================================
+ Hits 5995 5997 +2
Misses 667 667
Partials 203 203
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@frzifus Yea, let me take a look. I don't think there was a test for the current code so I may have to start from scratch. |
Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: Kevin Earls <kearls@redhat.com>
frzifus
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls kearls@redhat.com
This resolves #2088 If a base path is set in the CR and the streaming strategy is being used, we were not creating the ingress correctly.