-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query ingress when using streaming strategy #2120
Fix query ingress when using streaming strategy #2120
Conversation
Signed-off-by: Kevin Earls <kearls@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uff, would it make sense to persist that with a unittest?
Codecov ReportBase: 87.32% // Head: 87.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2120 +/- ##
=======================================
Coverage 87.32% 87.33%
=======================================
Files 100 100
Lines 6865 6867 +2
=======================================
+ Hits 5995 5997 +2
Misses 667 667
Partials 203 203
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@frzifus Yea, let me take a look. I don't think there was a test for the current code so I may have to start from scratch. |
Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: Kevin Earls <kearls@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: Kevin Earls kearls@redhat.com
This resolves #2088 If a base path is set in the CR and the streaming strategy is being used, we were not creating the ingress correctly.