Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Properly set imagePullPolicy and containerSecurityContext for EsIndexCleaner cronjob container #2224

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

michalschott
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • properly adds imagePullPolicy to EsIndexCleaner container
  • properly adds securityContext to EsIndexCleaner container
  • added tests for above use cases

…Cleaner cronjob container

Signed-off-by: Michal Schott <schott.michal@gmail.com>
@michalschott michalschott changed the title Properly set imagePullPolicy and containerSecurityContext for EsIndexCleaner cronjob container [BugFix] Properly set imagePullPolicy and containerSecurityContext for EsIndexCleaner cronjob container Jun 1, 2023
Copy link
Collaborator

@iblancasa iblancasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubenvp8510 can you enable the CI jobs?

@frzifus frzifus enabled auto-merge (squash) June 13, 2023 08:24
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6538461) 87.51% compared to head (348df97) 87.51%.

❗ Current head 348df97 differs from pull request most recent head 4ff9976. Consider uploading reports for the commit 4ff9976 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2224   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files         100      100           
  Lines        6912     6914    +2     
=======================================
+ Hits         6049     6051    +2     
  Misses        658      658           
  Partials      205      205           
Impacted Files Coverage Δ
pkg/cronjob/es_index_cleaner.go 84.61% <100.00%> (+0.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@michalschott
Copy link
Contributor Author

Correct me if I'm wrong, but I don't think the test failure is caused by this PR?

@frzifus
Copy link
Member

frzifus commented Jun 14, 2023

@michalschott no I think you are right. The CI system needs some love. All the e2e test stuff is unfortunately a bit messy. Let me re-run the test.

@frzifus frzifus merged commit 723105f into jaegertracing:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: securityContext and imagePullPolicy is not set for EsIndexCleaner container
3 participants