Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate ES certificated when is close to 1 day for expire #2356

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

rubenvp8510
Copy link
Collaborator

Which problem is this PR solving?

  • This solves the issue in which for some reason the reconciliation process doesn't trigger and the certificates expired, usually the reconciliation process should be triggered due a change in the CR or it's child resources or after 10hours, but it could happens that the certificate expires immediately or very close after a reconciliation call happens. Then we need to wait other 10 hours to have it renewed if nothing else triggers the reconciliation process.

Description of the changes

  • Check the certificates expiration, if those expires in 1 day, we renew it.

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@rubenvp8510
Copy link
Collaborator Author

@frzifus Can you review this one please?

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@rubenvp8510
Copy link
Collaborator Author

/retest-required

1 similar comment
@rubenvp8510
Copy link
Collaborator Author

/retest-required

@rubenvp8510
Copy link
Collaborator Author

/retest-required

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
@rubenvp8510
Copy link
Collaborator Author

/retest-required

Copy link

openshift-ci bot commented Nov 10, 2023

@rubenvp8510: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 929fc2c link unknown /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rubenvp8510 rubenvp8510 merged commit 2b0af44 into jaegertracing:main Nov 10, 2023
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants