Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preparing release v1.59.0 #2608

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Preparing release v1.59.0 #2608

merged 6 commits into from
Aug 6, 2024

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Jun 18, 2024

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

@frzifus
Preparing release v1.58.0
8e75a75 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
pavolloffay
pavolloffay reviewed Jun 18, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -1,5 +1,9 @@
Changes by Version
==================
## v1.58.0 (2024-05-06)
* Final deprecation of jaeger agent. Agents injected by the operator are no longer updated. newly created or updated Jaeger CRs with an agent configuration will be rejected. ([#2497](https://github.com/jaegertracing/jaeger-operator/pull/2497), [@frzifus](https://github.com/frzifus))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we document recommendation to use OTEL collector?

@pavolloffay
Copy link
Member

@frzifus I think it would make sense reject the request to the webhook when the mode is set to the sidecar. Now it seems only args are checked https://github.com/jaegertracing/jaeger-operator/pull/2497/files#diff-32094fefd1a64042b98c218228dd2d9b3e52ffcacc06f939ad6dabfdd7fb17a2R99

pavolloffay
pavolloffay requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove the daemonset code as well https://github.com/jaegertracing/jaeger-operator/blob/d6204bc2296648ee130c039ecfc4e8e71ca6a19a/pkg/inventory/daemonset.go

@frzifus frzifus mentioned this pull request Jun 27, 2024
Merged
4 tasks
@frzifus
changelog: remove jaeger deprecation entry
952779f 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus
Copy link
Member Author

frzifus commented Jun 27, 2024

Some deployments fail:

Deployment does not have minimum availability.

         status:
        -  readyReplicas: 1
        +  conditions:
        +  - lastTransitionTime: "2024-06-27T07:56:55Z"
        +    lastUpdateTime: "2024-06-27T07:56:55Z"
        +    message: Deployment does not have minimum availability.
        +    reason: MinimumReplicasUnavailable
        +    status: "False"
        +    type: Available
        +  - lastTransitionTime: "2024-06-27T07:56:55Z"
        +    lastUpdateTime: "2024-06-27T07:56:55Z"
        +    message: ReplicaSet "simple-streaming-ingester-5d586cb4d6" is progressing.
        +    reason: ReplicaSetUpdated
        +    status: "True"
        +    type: Progressing
        +  observedGeneration: 1
        +  replicas: 1
        +  unavailableReplicas: 1
        +  updatedReplicas: 1

@frzifus frzifus changed the title Preparing release v1.58.0 Preparing release v1.59.0 Jul 15, 2024
@frzifus frzifus force-pushed the prepare-1.58.0 branch 2 times, most recently from a0575d6 to eb87342 Compare August 5, 2024 10:18
@frzifus frzifus requested a review from pavolloffay August 5, 2024 13:16
@frzifus
Copy link
Member Author

frzifus commented Aug 5, 2024

If otlp is enabled and no explicit port for grpc or http is configured, we change the default address from localhost to 0.0.0.0.
See:

@frzifus
Prepare release v1.59.0
7611bad 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
frzifus commented Aug 5, 2024
View reviewed changes
config/manifests/bases/jaeger-operator.clusterserviceversion.yaml
@@ -15,7 +15,7 @@ metadata:
capabilities: Deep Insights
categories: Logging & Tracing
certified: "false"
containerImage: quay.io/jaegertracing/jaeger-operator:1.56.0
containerImage: quay.io/jaegertracing/jaeger-operator:1.59.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the 1.57 release did ship an old image. :b

yurishkuro
yurishkuro reviewed Aug 5, 2024
View reviewed changes
config/manifests/bases/jaeger-operator.clusterserviceversion.yaml
@@ -15,7 +15,7 @@ metadata:
capabilities: Deep Insights
categories: Logging & Tracing
certified: "false"
containerImage: quay.io/jaegertracing/jaeger-operator:1.56.0
containerImage: quay.io/jaegertracing/jaeger-operator:1.59.0
createdAt: "2023-05-16T04:47:12Z"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why you capture the date.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which date are you referring to? createdAt is displayed on the openshift operator hub and the community version (example).

AFAIK it has no additional meaning. While looking at it, its a but weird, that there is no updatedAt filed.

@frzifus frzifus force-pushed the prepare-1.58.0 branch 2 times, most recently from 208ed5f to 2e9ab66 Compare August 6, 2024 13:20
@frzifus
otlp: set default host:port when not provided
ccb4522 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
pavolloffay
pavolloffay reviewed Aug 6, 2024
View reviewed changes
versions.txt

# DO NOT EDIT the next value, it is updated automatically during the release.
# Represents the current (latest) release of the Jaeger Operator.
operator=1.57.0
operator=1.59.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/jaegertracing/jaeger-operator/blob/main/RELEASE.md#releasing

Change the versions.txt so that it lists the target version of the Jaeger (if it is required). Don't touch the operator version: it will be changed automatically in the next step.

@frzifus
Copy link
Member Author

frzifus commented Aug 6, 2024

FTR: We skipped 1.58.
image

@frzifus frzifus requested a review from pavolloffay August 6, 2024 14:12
@yurishkuro
Copy link
Member

Maybe you want to skip 1.59 and go to 1.60 (just released)?

@frzifus
Update bundle/manifests/jaeger-operator.clusterserviceversion.yaml
c1868ea 
Signed-off-by: Ben B. <bongartz@klimlive.de>
@frzifus frzifus requested a review from pavolloffay August 6, 2024 16:30
@frzifus frzifus merged commit 03de379 into jaegertracing:main Aug 6, 2024
21 checks passed
@frzifus frzifus deleted the prepare-1.58.0 branch August 6, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro left review comments

@iblancasa iblancasa iblancasa approved these changes

@rubenvp8510 rubenvp8510 Awaiting requested review from rubenvp8510

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frzifus @pavolloffay @yurishkuro @iblancasa