Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use client certs for elasticsearch #325

Merged
merged 5 commits into from
Mar 20, 2019

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Mar 18, 2019

Resolves #310
Blocked by #324 and Elasticsearch Image openshift/origin-aggregated-logging#1561

Signed-off-by: Pavol Loffay ploffay@redhat.com

@jpkrohling
Copy link
Contributor

This change is Reviewable

@pavolloffay pavolloffay changed the title Use client certs for elasticsearch WIP: Use client certs for elasticsearch Mar 18, 2019
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #325 into master will increase coverage by 0.9%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #325     +/-   ##
=========================================
+ Coverage    88.8%   89.71%   +0.9%     
=========================================
  Files          69       64      -5     
  Lines        3154     2985    -169     
=========================================
- Hits         2801     2678    -123     
+ Misses        239      207     -32     
+ Partials      114      100     -14
Impacted Files Coverage Δ
pkg/strategy/production.go 77.41% <ø> (+8.84%) ⬆️
pkg/strategy/strategy.go 91.52% <ø> (+13.26%) ⬆️
pkg/controller/jaeger/jaeger_controller.go 40.2% <ø> (+1.59%) ⬆️
pkg/storage/elasticsearch.go 82.22% <100%> (+0.68%) ⬆️
pkg/storage/elasticsearch_secrets.go 92.39% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca44c74...b23c43c. Read the comment docs.

Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay pavolloffay changed the title WIP: Use client certs for elasticsearch Use client certs for elasticsearch Mar 19, 2019
@pavolloffay pavolloffay requested review from jpkrohling and objectiser and removed request for jpkrohling March 19, 2019 15:41
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
@pavolloffay pavolloffay merged commit c1e8337 into jaegertracing:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants