-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use client certs for elasticsearch #325
Merged
pavolloffay
merged 5 commits into
jaegertracing:master
from
pavolloffay:es-client-certs
Mar 20, 2019
Merged
Use client certs for elasticsearch #325
pavolloffay
merged 5 commits into
jaegertracing:master
from
pavolloffay:es-client-certs
Mar 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
changed the title
Use client certs for elasticsearch
WIP: Use client certs for elasticsearch
Mar 18, 2019
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
es-client-certs
branch
from
March 19, 2019 13:56
2c33264
to
3b9c93b
Compare
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=========================================
+ Coverage 88.8% 89.71% +0.9%
=========================================
Files 69 64 -5
Lines 3154 2985 -169
=========================================
- Hits 2801 2678 -123
+ Misses 239 207 -32
+ Partials 114 100 -14
Continue to review full report at Codecov.
|
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
changed the title
WIP: Use client certs for elasticsearch
Use client certs for elasticsearch
Mar 19, 2019
pavolloffay
requested review from
jpkrohling and
objectiser
and removed request for
jpkrohling
March 19, 2019 15:41
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
objectiser
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #310
Blocked by #324 and Elasticsearch Image openshift/origin-aggregated-logging#1561Signed-off-by: Pavol Loffay ploffay@redhat.com