Allow setting es-operator-image #549
Conversation
Signed-off-by: Kevin Earls <kearls@redhat.com>
Makefile
Outdated
| @@ -16,7 +16,8 @@ OPERATOR_VERSION ?= "$(shell git describe --tags)" | |||
| STORAGE_NAMESPACE ?= "${shell kubectl get sa default -o jsonpath='{.metadata.namespace}' || oc project -q}" | |||
| KAFKA_NAMESPACE ?= "kafka" | |||
| ES_OPERATOR_NAMESPACE = openshift-logging | |||
| ES_OPERATOR_VERSION = 4.1 | |||
| ES_OPERATOR_VERSION ?= release-4.1 | |||
There was a problem hiding this comment.
Would it be better to rename as ES_OPERATOR_BRANCH?
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 69 69
Lines 3504 3504
=======================================
Hits 3223 3223
Misses 196 196
Partials 85 85Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
=======================================
Coverage 91.98% 91.98%
=======================================
Files 69 69
Lines 3504 3504
=======================================
Hits 3223 3223
Misses 196 196
Partials 85 85Continue to review full report at Codecov.
|
Signed-off-by: Kevin Earls <kearls@redhat.com>
Makefile
Outdated
| @kubectl apply -f https://raw.githubusercontent.com/openshift/elasticsearch-operator/${ES_OPERATOR_BRANCH}/manifests/02-role.yaml | ||
| @kubectl apply -f https://raw.githubusercontent.com/openshift/elasticsearch-operator/${ES_OPERATOR_BRANCH}/manifests/03-role-bindings.yaml | ||
| @kubectl apply -f https://raw.githubusercontent.com/openshift/elasticsearch-operator/${ES_OPERATOR_BRANCH}/manifests/04-crd.yaml -n ${ES_OPERATOR_NAMESPACE} | ||
| kubectl apply -f https://raw.githubusercontent.com/openshift/elasticsearch-operator/${ES_OPERATOR_BRANCH}/manifests/05-deployment.yaml -n ${ES_OPERATOR_NAMESPACE} |
There was a problem hiding this comment.
nit: Can the @ symbols be added back to this and next line?
Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: Kevin Earls kearls@redhat.com
Allow setting the elasticsearch operator image via an environment variable. This is needed for CI for compatibility testing.