-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commonSpec to other jobs (es-index-cleaner, es-rollover, cassandr… #640
Conversation
…a-create-schema) Signed-off-by: Gary Brown <gary@brownuk.com>
@jpkrohling Seems like a problem with the github actions, created a fresh PR (not rebased) - failed on streaming test first time around (with 2 other e2e tests cancelled) but then when restarted it complains on the checkout. Any idea how best to proceed? |
Are you or @kevinearls able to run the e2e tests for Cassandra locally? If they succeed, I'm comfortable in merging this, as that's the only one that hasn't succeeded between all the runs. |
@kevinearls Thanks - I've just done a minor refactor so will see if tests are working better today. Could you try running all of the e2e tests locally based on this updated PR? When I tried the cassandra test it timed out - but will try again. |
@objectiser Sure, I'll try it shortly. |
@jpkrohling @objectiser Sorry, but my earlier comments were incorrect. In fact I cannot get the cassandra test tor work with this PR. Both test cases fail. |
@kevinearls Ok thanks Kevin - I'll take anothe look. |
Signed-off-by: Gary Brown <gary@brownuk.com>
@kevinearls I've updated to remove the common spec from the cassandra create schema job for now - all e2e tests run fine locally except the streaming one timed out - could you try running all the tests locally to see what results you see? Thanks. |
@jpkrohling Looks like all is ok now :) |
LGTM! Feel free to merge if you think it's ready. Should I start the release process after this one gets merged? |
@jpkrohling yes I think the release should be done. |
…a-create-schema)
Signed-off-by: Gary Brown gary@brownuk.com