Removed descriptions from CRD #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
objectiser
approved these changes
Feb 28, 2020
Closed
26 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #873 and is related to #854. In this PR, I'm removing the description fields, as suggested by @adamhosier in #873. Note that we are moving away from the
operator-sdk's CRD generator in favor ofcontroller-gen. The Operator SDK does use the same bits ascontroller-genunder the hood, and I understand that the plan is to move more and more in the direction ofkubebuilder. So, there's low risk that we'll diverge that much from the operator-sdk.Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de