Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored the displayName in the CSV #987

Merged

Conversation

jpkrohling
Copy link
Contributor

For some reason, the generated CSV for 1.17.1 is missing the displayName. When installing a bundle from the current master, the operator fails to install because of the missing field.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling
Copy link
Contributor Author

cc @jkandasa

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #987 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #987   +/-   ##
=======================================
  Coverage   64.44%   64.44%           
=======================================
  Files          82       82           
  Lines        6526     6526           
=======================================
  Hits         4206     4206           
  Misses       2178     2178           
  Partials      142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2cff4...1a7bd45. Read the comment docs.

@@ -77,6 +77,7 @@ spec:
customresourcedefinitions:
owned:
- description: Jaeger is the Schema for the jaegers API
displayName: Jaeger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this has to be done manually after every generate then it should be documented somewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there's an annotation missing somewhere, or if it's a bug in the CSV generator. Something to be investigated as part of another task.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that we will probably forget to change this during the next release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with you. I do suggest creating another task to investigate this, either to fix the problem or to document it in the release instructions.

@jpkrohling jpkrohling merged commit 800b393 into jaegertracing:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants