Skip to content

Commit

Permalink
ci: simplify check-label workflow (#2068)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
Fixes #2067 

## Description of the changes
Removes the `set-output` command from the workflow

## How was this change tested?
NA

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [X] I have signed all commits
- [X] I have added unit tests for the new functionality
- [X] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Eshaan Aggarwal <96648934+EshaanAgg@users.noreply.github.com>
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
  • Loading branch information
EshaanAgg and yurishkuro authored Dec 24, 2023
1 parent 33b22a4 commit 4fefcac
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/ci-label-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,8 @@ jobs:
check-label:
runs-on: ubuntu-latest
steps:
- name: Check PR author
id: check_author
run: echo "::set-output name=is_dependabot::$(echo ${{ github.event.pull_request.user.login }} | grep -o 'dependabot')"

- name: Check PR label
if: steps.check_author.outputs.is_dependabot != 'dependabot'
if: github.event.pull_request.user.login != 'dependabot'
run: |
LABEL_NAME="changelog:"
if [[ $(curl -s "https://api.github.com/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}" | jq -r '.labels[].name' | grep -c "^$LABEL_NAME") -eq 0 ]]; then
Expand Down

0 comments on commit 4fefcac

Please sign in to comment.