-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: upgrade graph layout library #1081
Comments
Resolves #1077. The upgrade was introduced in #1001. Sadly, we have no unit tests in `/plexus/` module, so the break was not caught. In #1001 the dependency viz.js was upgraded to the next major version (2.1.2), however it had breaking changes which were not accounted for. Alternative paths tracked in #1081.
@yurishkuro can u assign this to me ? I would like to work on this . |
@yurishkuro I understand the need to streamline and update the graph visualization dependencies but I wanted to seek clarification on what exactly you mean by "confusing". |
There is no good explanation in the UI why there are two graphs for overall topology. Practically, this was done more for technical reasons, but that doesn't need to be exposed to the user. |
may not be needed anymore, due to upgrade in #2568 |
Jaeger depends on a number of deprecated graph layout libs, like
dagre
andviz.js
. It also provides a confusing assortment of graph views (force directed, DAG, and the latest graphs via plexus).To avoid getting blocked on very old dependencies, we need to move to something newer.
One option to investigate: https://github.com/erikbrinkman/d3-dag
The text was updated successfully, but these errors were encountered: