-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: jaeger-ui fails to compile on s390x due to a dependency on lerna/nx #1996
Comments
The I think the easiest way is to drop the |
Getting rid of lerna would be great. Unless it's a completely trivial change, please post some plan / findings on #341 first. |
lerna/nx does not support s390x: https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161 https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms Resolves: jaegertracing#1996 Resolves: jaegertracing#341 Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
imho it's a trivial change, mainly replacing This also removes lots of dependencies from |
## Which problem is this PR solving? lerna/nx does not support s390x, and therefore the jaeger-ui build fails on this platform. This PR removes the lerna dependency from jaeger-ui. https://github.com/nrwl/nx/blob/16.6.0/packages/nx/src/native/index.js#L161 https://github.com/nrwl/nx/blob/16.6.0/docs/shared/installation/troubleshoot-installation.md#supported-native-module-platforms Resolves: #1996 Resolves: #341 ## Description of the changes Remove `lerna` and use `yarn workspaces` instead. ## How was this change tested? - local ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
What happened?
As a maintainer I want to compile jaeger-ui on s390x.
Steps to reproduce
yarn install --frozen-lockfile
Expected behavior
Build fails with
Error: Unsupported architecture on Linux: s390x
Relevant log output
The text was updated successfully, but these errors were encountered: