Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade antd and icons #2576

Open
2 tasks
yurishkuro opened this issue Jan 9, 2025 · 3 comments
Open
2 tasks

Upgrade antd and icons #2576

yurishkuro opened this issue Jan 9, 2025 · 3 comments
Labels
good first issue help wanted

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jan 9, 2025 •
edited
Loading

Automatic upgrades are failing

There are probably some minor API changes. But since this affects the visualization, a fix should include before/after screenshots of the changed components, to verify continuity.

  • antd
  • react-icons
@manzil-infinity180 manzil-infinity180 mentioned this issue Jan 10, 2025
Merged
4 tasks
@141AQUA-xzy
Copy link

i would like to work on this issue

yurishkuro pushed a commit that referenced this issue Jan 10, 2025
@manzil-infinity180
Upgrade antd to v5.23.0 from v5.21.3 (#2579)
2a0a8d3 
## Which problem is this PR solving?
Issue #2576


## Description of the changes
* Antd moved from tinycolor to fast-color in their new minor changes
ant-design/ant-design#52107
* I removed/uninstall the @ctrl/tinycolor module and re-install the antd
to latest version as per this
[docs](https://ant.design/docs/react/migration-v5)

## How was this change tested?
* automated testing
* some changes to snapshot (npm run test-ci -- -u) 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Rahul Vishwakarma <rahulvs2809@gmail.com>
@yurishkuro
Copy link
Member Author

#2579 reverted in #2587

@coderboy-yash
Copy link

coderboy-yash commented Jan 18, 2025 •
edited
Loading

@yurishkuro
i want to work on this issue, I have some clarifying questions:-

  1. I have to update the antd dependency to v 5.23.1 ?
  2. I have to update the react-icons dependency to v 5.4.0 ?
  3. I am right or there is something else I am required to do ?

This was referenced Jan 18, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yurishkuro @coderboy-yash @141AQUA-xzy