Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search] Multiple searches can cause the wrong results to show #288

Closed
tiffon opened this issue Dec 2, 2018 · 0 comments · Fixed by #286
Closed

[Search] Multiple searches can cause the wrong results to show #288

tiffon opened this issue Dec 2, 2018 · 0 comments · Fixed by #286
Assignees
@tiffon
Labels
bug

Comments

@tiffon
Copy link
Member

tiffon commented Dec 2, 2018

Requirement - what kind of business use case are you trying to solve?

Show search results for the last executed search, only.

Problem - what in Jaeger blocks you from solving the requirement?

When multiple searches are executed, they are shown in the order they finish. The last search to finish is the result set that shows when all is said and done, regardless of whether or not it was the last requested search. This can not only show results from a former search but also results that don't match the search form (if it was modified for a subsequent search).

Proposal - what do you suggest to solve the problem or improve the existing situation?

Only show the last request search results. E.g. if multiple searches are executed, do not show any results except the last.
@tiffon tiffon added the bug label Dec 2, 2018
@tiffon tiffon self-assigned this Dec 2, 2018
tiffon added a commit that referenced this issue Dec 2, 2018
@tiffon
Keep redux search query synced with results
5814f6c 
- Keep redux search query synced with redux search result (and their
  processing). Also fixes #288.

- Bolster unit tests

Signed-off-by: Joe Farro <joef@uber.com>
@tiffon tiffon mentioned this issue Dec 2, 2018
Merged
1 task
tiffon added a commit that referenced this issue Dec 20, 2018
@tiffon
Revisions for search and trace detail embed mode (#286)
53937eb 
* Misc tweaks for search and trace detail embed mode

Mostly from prior comments.

- Rename query parameter for embedding to start with "ui" and use the
  page as the first word, e.g. "uiSearchHideGraph"

- Change query parameters for the minimap and trace details from hiding
  to showing, e.g. "hidemap" -> "uiTimelineShowMap"

- Save the embed query params in Redux state instead of passing them
  around

- Use a Link with an icon instead of text buttons for opening the
  standalone view of the page

- Propagate whether the trace detail page is from the search page or
  not via the Location#state member on the React Router Location

- When returning to the search page use the previous results instead
  of executing a new search. This is done by storing the query with
  the search results.

- Adjusted aesthetic of "Back to Search" button on trace detail page

- Sequester parsing and stripping query parameters for the embed mode
  to a util

- In various places switch to using the component/*/url.js#getUrl
  functions instead of prefixUrl(...)

Signed-off-by: Joe Farro <joef@uber.com>

* Fix test break from merging master

Signed-off-by: Joe Farro <joef@uber.com>

* Keep redux search query synced with results

- Keep redux search query synced with redux search result (and their
  processing). Also fixes #288.

- Bolster unit tests

Signed-off-by: Joe Farro <joef@uber.com>

* Fix typo

Signed-off-by: Joe Farro <joef@uber.com>

* Make TracePageHeader collapsible when embedded

- Reconfigured embed query parameters for timeline:

  - uiTimelineCollapseTitle=1 - TracePageHeader starts out collapsed

  - uiTimelineHideMinimap=1 - TracePageHeader does not show the minimap

  - uiTimelineHideSummary=1 - TracePageHeader does not show the trace
    summary

- Consolidate TracePageHeader and TracePageHeaderEmbed

- Style changes to TracePageHeader

- Embedded TracePageHeader can now be expanded and collapsed

- Misc cleanup in TracePageHeader

- Better comparisons for search page query to prevent re-fetching
  when returning to the search page

Signed-off-by: Joe Farro <joef@uber.com>

* Fix typo disableComparisions

Signed-off-by: Joe Farro <joef@uber.com>

* Use public registry to newly installed packages

Signed-off-by: Joe Farro <joef@uber.com>

* Test improvements

Signed-off-by: Joe Farro <joef@uber.com>
everett980 pushed a commit to everett980/jaeger-ui that referenced this issue Jan 16, 2019
@tiffon @everett980
Revisions for search and trace detail embed mode (jaegertracing#286)
4112482 
* Misc tweaks for search and trace detail embed mode

Mostly from prior comments.

- Rename query parameter for embedding to start with "ui" and use the
  page as the first word, e.g. "uiSearchHideGraph"

- Change query parameters for the minimap and trace details from hiding
  to showing, e.g. "hidemap" -> "uiTimelineShowMap"

- Save the embed query params in Redux state instead of passing them
  around

- Use a Link with an icon instead of text buttons for opening the
  standalone view of the page

- Propagate whether the trace detail page is from the search page or
  not via the Location#state member on the React Router Location

- When returning to the search page use the previous results instead
  of executing a new search. This is done by storing the query with
  the search results.

- Adjusted aesthetic of "Back to Search" button on trace detail page

- Sequester parsing and stripping query parameters for the embed mode
  to a util

- In various places switch to using the component/*/url.js#getUrl
  functions instead of prefixUrl(...)

Signed-off-by: Joe Farro <joef@uber.com>

* Fix test break from merging master

Signed-off-by: Joe Farro <joef@uber.com>

* Keep redux search query synced with results

- Keep redux search query synced with redux search result (and their
  processing). Also fixes jaegertracing#288.

- Bolster unit tests

Signed-off-by: Joe Farro <joef@uber.com>

* Fix typo

Signed-off-by: Joe Farro <joef@uber.com>

* Make TracePageHeader collapsible when embedded

- Reconfigured embed query parameters for timeline:

  - uiTimelineCollapseTitle=1 - TracePageHeader starts out collapsed

  - uiTimelineHideMinimap=1 - TracePageHeader does not show the minimap

  - uiTimelineHideSummary=1 - TracePageHeader does not show the trace
    summary

- Consolidate TracePageHeader and TracePageHeaderEmbed

- Style changes to TracePageHeader

- Embedded TracePageHeader can now be expanded and collapsed

- Misc cleanup in TracePageHeader

- Better comparisons for search page query to prevent re-fetching
  when returning to the search page

Signed-off-by: Joe Farro <joef@uber.com>

* Fix typo disableComparisions

Signed-off-by: Joe Farro <joef@uber.com>

* Use public registry to newly installed packages

Signed-off-by: Joe Farro <joef@uber.com>

* Test improvements

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@tiffon
Revisions for search and trace detail embed mode (jaegertracing#286)
4431f1e 
* Misc tweaks for search and trace detail embed mode

Mostly from prior comments.

- Rename query parameter for embedding to start with "ui" and use the
  page as the first word, e.g. "uiSearchHideGraph"

- Change query parameters for the minimap and trace details from hiding
  to showing, e.g. "hidemap" -> "uiTimelineShowMap"

- Save the embed query params in Redux state instead of passing them
  around

- Use a Link with an icon instead of text buttons for opening the
  standalone view of the page

- Propagate whether the trace detail page is from the search page or
  not via the Location#state member on the React Router Location

- When returning to the search page use the previous results instead
  of executing a new search. This is done by storing the query with
  the search results.

- Adjusted aesthetic of "Back to Search" button on trace detail page

- Sequester parsing and stripping query parameters for the embed mode
  to a util

- In various places switch to using the component/*/url.js#getUrl
  functions instead of prefixUrl(...)

Signed-off-by: Joe Farro <joef@uber.com>

* Fix test break from merging master

Signed-off-by: Joe Farro <joef@uber.com>

* Keep redux search query synced with results

- Keep redux search query synced with redux search result (and their
  processing). Also fixes jaegertracing#288.

- Bolster unit tests

Signed-off-by: Joe Farro <joef@uber.com>

* Fix typo

Signed-off-by: Joe Farro <joef@uber.com>

* Make TracePageHeader collapsible when embedded

- Reconfigured embed query parameters for timeline:

  - uiTimelineCollapseTitle=1 - TracePageHeader starts out collapsed

  - uiTimelineHideMinimap=1 - TracePageHeader does not show the minimap

  - uiTimelineHideSummary=1 - TracePageHeader does not show the trace
    summary

- Consolidate TracePageHeader and TracePageHeaderEmbed

- Style changes to TracePageHeader

- Embedded TracePageHeader can now be expanded and collapsed

- Misc cleanup in TracePageHeader

- Better comparisons for search page query to prevent re-fetching
  when returning to the search page

Signed-off-by: Joe Farro <joef@uber.com>

* Fix typo disableComparisions

Signed-off-by: Joe Farro <joef@uber.com>

* Use public registry to newly installed packages

Signed-off-by: Joe Farro <joef@uber.com>

* Test improvements

Signed-off-by: Joe Farro <joef@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this issue Jul 5, 2021
@tiffon @everett980
Revisions for search and trace detail embed mode (jaegertracing#286)
64c14dd 
* Misc tweaks for search and trace detail embed mode

Mostly from prior comments.

- Rename query parameter for embedding to start with "ui" and use the
  page as the first word, e.g. "uiSearchHideGraph"

- Change query parameters for the minimap and trace details from hiding
  to showing, e.g. "hidemap" -> "uiTimelineShowMap"

- Save the embed query params in Redux state instead of passing them
  around

- Use a Link with an icon instead of text buttons for opening the
  standalone view of the page

- Propagate whether the trace detail page is from the search page or
  not via the Location#state member on the React Router Location

- When returning to the search page use the previous results instead
  of executing a new search. This is done by storing the query with
  the search results.

- Adjusted aesthetic of "Back to Search" button on trace detail page

- Sequester parsing and stripping query parameters for the embed mode
  to a util

- In various places switch to using the component/*/url.js#getUrl
  functions instead of prefixUrl(...)

Signed-off-by: Joe Farro <joef@uber.com>

* Fix test break from merging master

Signed-off-by: Joe Farro <joef@uber.com>

* Keep redux search query synced with results

- Keep redux search query synced with redux search result (and their
  processing). Also fixes jaegertracing#288.

- Bolster unit tests

Signed-off-by: Joe Farro <joef@uber.com>

* Fix typo

Signed-off-by: Joe Farro <joef@uber.com>

* Make TracePageHeader collapsible when embedded

- Reconfigured embed query parameters for timeline:

  - uiTimelineCollapseTitle=1 - TracePageHeader starts out collapsed

  - uiTimelineHideMinimap=1 - TracePageHeader does not show the minimap

  - uiTimelineHideSummary=1 - TracePageHeader does not show the trace
    summary

- Consolidate TracePageHeader and TracePageHeaderEmbed

- Style changes to TracePageHeader

- Embedded TracePageHeader can now be expanded and collapsed

- Misc cleanup in TracePageHeader

- Better comparisons for search page query to prevent re-fetching
  when returning to the search page

Signed-off-by: Joe Farro <joef@uber.com>

* Fix typo disableComparisions

Signed-off-by: Joe Farro <joef@uber.com>

* Use public registry to newly installed packages

Signed-off-by: Joe Farro <joef@uber.com>

* Test improvements

Signed-off-by: Joe Farro <joef@uber.com>
Signed-off-by: Everett Ross <reverett@uber.com>

Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tiffon tiffon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revisions for search and trace detail embed mode jaegertracing/jaeger-ui
1 participant
@tiffon