Extend JSON file reader to handle array of objects with resourceSpans

[Adarsh-jaiss]

Which problem is this PR solving?

• Resolves [Bug]: Importing OTLP "File Exporter" JSON fails #2225

Description of the changes

• This commit updates the JSON file reader function to handle an array of JSON objects containing 'resourceSpans' arrays. It now merges these arrays into a single 'resourceSpans' array before processing, ensuring compatibility with both single JSON objects and arrays of objects.

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[yurishkuro]

Please add a unit test

[Adarsh-jaiss]

Hey @yurishkuro , I made the signigicant changes :

try {
        let traceObj = JSON.parse(reader.result);
        if (Array.isArray(traceObj) && traceObj.every(obj => 'resourceSpans' in obj)) {
          const mergedResourceSpans = traceObj.reduce((acc, obj) => {
            acc.push(...obj.resourceSpans);
            return acc;
          }, []);

          traceObj = { resourceSpans: mergedResourceSpans };
        }
        if ('resourceSpans' in traceObj) {
          JaegerAPI.transformOTLP(traceObj)
            .then((result: string) => {
              resolve(result);
            })
            .catch(() => {
              reject(new Error(`Error converting traces to OTLP`));
            });
        }
      } catch (error: unknown) {
        reject(new Error(`Error parsing JSON: ${(error as Error).message}`));
      }
    };

and added these test cases :

  it('loads JSON data with single resourceSpans array successfully', async () => {
    const obj = { resourceSpans: [{ id: 1 }, { id: 2 }, { id: 3 }] };
    const file = new File([JSON.stringify(obj)], 'singleResourceSpans.json');
    const result = await readJsonFile({ file });
    expect(result).toEqual(JSON.stringify(obj));
  });

  it('loads JSON data with multiple resourceSpans arrays successfully', async () => {
    const obj1 = { resourceSpans: [{ id: 1 }, { id: 2 }] };
    const obj2 = { resourceSpans: [{ id: 3 }, { id: 4 }] };
    const file = new File([JSON.stringify([obj1, obj2])], 'multipleResourceSpans.json');
    const expectedResult = { resourceSpans: [...obj1.resourceSpans, ...obj2.resourceSpans] };
    const result = await readJsonFile({ file });
    expect(result).toEqual(JSON.stringify(expectedResult));
  });

and after running npm test, I'm getting this result :

Can you please help me out on this?

[yurishkuro]

please push your changes, I cannot troubleshoot via screenshots

[Adarsh-jaiss]

• Hey @yurishkuro , I have pushed the code, kindly look into it!

[yurishkuro]

yarn lint and yarn test are failing

[yurishkuro]

I don't think this test is needed, if you can process array of size>1 you can certainly process size=1

[yurishkuro]

this is not a valid OTEL structure, it should be something like resourceSpans > scopeSpans > spans

[yurishkuro]

addressed in #2380