added function to show full traceID in #2536
Conversation
Signed-off-by: Avinash <avinashchowdhury81@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2536 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 255 255
Lines 7732 7733 +1
Branches 2009 1996 -13
=======================================
+ Hits 7468 7469 +1
Misses 264 264 ☔ View full report in Codecov by Sentry. |
|
looks great ... but IMHO it takes extra space as it's showing the User same information as it's already available on top. what you can do is that make the shorten traceID clickable and then clicking on it would expand to show Full ID and again clicking on it would collapse it. This would also clean-up the UI and IMO would be a better UX design |
Thanks! I'll make TraceID clickable for better UX |
Signed-off-by: Avinash <avinashchowdhury81@gmail.com>
|
Hey @MAX-786 |
|
@avinpy-255 Hi, |
|
The original issue was asking for configuration to make the trace ID displayed in full. There is no configuration added in this PR. The configuration can be specifying the desired length from the ID to display, e.g. 32 would display full ID. |
Signed-off-by: Avinash <avinashchowdhury81@gmail.com>
| @@ -20,6 +20,8 @@ import getVersion from '../utils/version/get-version'; | |||
| import { version } from '../../package.json'; | |||
| import { Config } from '../types/config'; | |||
|
|
|||
| export const TraceIDLength = 7; | |||
There was a problem hiding this comment.
we don't use constants for anything else, just use the value directly
| @@ -149,7 +150,7 @@ export function TracePageHeaderFn(props: TracePageHeaderEmbedProps & { forwarded | |||
| return { ...rest, value: renderer(trace) }; | |||
| }); | |||
|
|
|||
| const traceShortID = trace.traceID.slice(0, 7); | |||
| const traceShortID = trace.traceID.slice(0, TraceIDLength); | |||
There was a problem hiding this comment.
ok, I will add a test for tracIDlength
Signed-off-by: avinash <avinashchowdhury81@gmail.com>
Which problem is this PR solving?
Description of the changes
How was this change tested?
here is the screenshot of the function Full ID
after clicking the Full ID
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test