-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]: Remove redux-form dependency from sort selector #2569
[fix]: Remove redux-form dependency from sort selector #2569
Conversation
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2569 +/- ##
==========================================
- Coverage 96.63% 96.58% -0.06%
==========================================
Files 255 255
Lines 7731 7732 +1
Branches 2012 2009 -3
==========================================
- Hits 7471 7468 -3
- Misses 260 264 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
export const middlewareHooks = { | ||
[constants.FORM_CHANGE_ACTION_TYPE]: (_: Store<ReduxState>, action: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was is only used for tracking Sort Selector changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Looking into the codebase, this middlewareHooks
had only one if condition that was checking if the action dispatched via redux-form
has the .meta
property as sortBy
which is possible for only sort selector.
I couldn't find other pages (other than Trace Results page) where a similar sorting selector is used.
Which problem is this PR solving?
Description of the changes
handleSortChange
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test