[Deps]: Remove dependency on redux-form #2593
Conversation
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2593 +/- ##
==========================================
+ Coverage 96.58% 96.61% +0.03%
==========================================
Files 255 255
Lines 7732 7744 +12
Branches 2009 1998 -11
==========================================
+ Hits 7468 7482 +14
+ Misses 264 262 -2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
| <Popover placement="bottomLeft" open={isInvalid} {...validationResult}> | ||
| <Input | ||
| className={cx({ | ||
| 'duration-is-invalid': isInvalid, |
There was a problem hiding this comment.
this appears to be a generic form field component, why is style called duration-*?
There was a problem hiding this comment.
yes, that's a generic component but is currently used for duration fields (minDuration and maxDuration) in the Search Sidebar form. I will rename that to a more generic classname, if there arise any use case for this component in other part of the code.
| @@ -0,0 +1,46 @@ | |||
| // Copyright (c) 2017 Uber Technologies, Inc. | |||
There was a problem hiding this comment.
Is this file copied from somewhere? If it's brand new the header should be
// Copyright (c) 2025 The Jaeger Authors.
// SPDX-License-Identifier: Apache-2.0
(same for the test file)
There was a problem hiding this comment.
It's not copied. I created this custom component
| @@ -16,4 +16,4 @@ export const DEFAULT_OPERATION = 'all'; | |||
| export const DEFAULT_LOOKBACK = '1h'; | |||
| export const DEFAULT_LIMIT = 20; | |||
|
|
|||
| export const FORM_CHANGE_ACTION_TYPE = '@@redux-form/CHANGE'; | |||
| export const FORM_CHANGE_ACTION_TYPE = '@@redux/searchSideBar/CHANGE_SERVICE'; | |||
There was a problem hiding this comment.
FORM_CHANGE is a very generic name while the event seems to be a change in a single specific dropdown
| @@ -673,23 +719,19 @@ export function mapStateToProps(state) { | |||
| traceIDs: traceIDs || null, | |||
| }, | |||
| searchMaxLookback: _get(state, 'config.search.maxLookback'), | |||
| selectedService: searchSideBarFormSelector(state, 'service'), | |||
| selectedLookback: searchSideBarFormSelector(state, 'lookback'), | |||
There was a problem hiding this comment.
no replacement for this one?
There was a problem hiding this comment.
redux-form maps the redux state to props and those props are then used in the component. These values were being populated after a user selects a service or lookback and are then used to conditionally show the startDate startDateTime endDate endDateTime fields, and also to trigger the middleware to load updated operations for the selectedService.
This whole state is now being selected from fromData state, so there's no need for a replacement for this
Signed-off-by: Hariom Gupta <guptahariom03082003@gmail.com>
Which problem is this PR solving?
Description of the changes
ValidatedFormFieldcomponent is created to handle the Validated minDuration and maxDuration fields that require validation andPopoverto be displayed on failed validations.redux-formfield, but would now trigger on selecting a new service from Service Selector.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test