Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jest to produce a junit report for tests #723

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Update jest to produce a junit report for tests #723

merged 2 commits into from
Apr 2, 2021

Conversation

kevinearls
Copy link
Contributor

Signed-off-by: Kevin Earls kearls@redhat.com

Which problem is this PR solving?

  • It would be useful to be able to produce a JUnit type report in CI when tests are run.

Short description of the changes

  • Add a jest-junit reporter to packages/jaeger-ui/package.json to product a junit.xml report whenever tests are run.

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: Kevin Earls <kearls@redhat.com>
@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #723 (e644de4) into master (30d5b94) will not change coverage.
The diff coverage is n/a.

❗ Current head e644de4 differs from pull request most recent head c66edae. Consider uploading reports for the commit c66edae to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #723   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files         230      230           
  Lines        5959     5959           
  Branches     1448     1448           
=======================================
  Hits         5625     5625           
  Misses        300      300           
  Partials       34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d5b94...c66edae. Read the comment docs.

@yurishkuro
Copy link
Member

What is the practical impact of this? Is there something new being printed in CI?

@kevinearls
Copy link
Contributor Author

@yurishkuro When you run yarn test it creates a standard junit type report in packages/jaeger-ui/junit.xml

@yurishkuro yurishkuro merged commit dcd91c2 into jaegertracing:master Apr 2, 2021
@kevinearls kevinearls deleted the add-junit-jest-reporter branch April 6, 2021 07:11
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jun 23, 2021
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <kearls@redhat.com>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <kearls@redhat.com>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <kearls@redhat.com>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <kearls@redhat.com>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <kearls@redhat.com>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <kearls@redhat.com>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <kearls@redhat.com>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 4, 2021
* Update jest to produce a junit report for tests

Signed-off-by: Kevin Earls <kearls@redhat.com>

* Fix formatting to make yarn lint happy

Signed-off-by: Kevin Earls <kearls@redhat.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants