Skip to content

Commit

Permalink
Dep migration (#1240)
Browse files Browse the repository at this point in the history
* Migrate to dep

Signed-off-by: Isaac Hier <isaachier@gmail.com>

* Warn on install-glide and redirect to use dep

Signed-off-by: Isaac Hier <ihier@uber.com>
  • Loading branch information
isaachier authored and yurishkuro committed Dec 7, 2018
1 parent 7b18bd9 commit 5f6af99
Show file tree
Hide file tree
Showing 9 changed files with 1,073 additions and 490 deletions.
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ We gratefully welcome improvements to documentation as well as to code.

## Getting Started

This library uses [glide](https://github.com/Masterminds/glide) to manage dependencies.
This library uses [dep](https://golang.github.io/dep) to manage dependencies.

To get started, make sure you clone the Git repository into the correct location `github.com/jaegertracing/jaeger` relative to `$GOPATH`:

Expand All @@ -28,7 +28,7 @@ Then install dependencies and run the tests:

```
git submodule update --init --recursive
glide install
dep ensure
make test
```

Expand Down Expand Up @@ -84,7 +84,7 @@ github.com/jaegertracing/jaeger
jaeger/
sampling/
zipkincore/
glide.yaml - Glide is the project's dependency manager
Gopkg.toml - Dep is the project's dependency manager
mkdocs.yml - MkDocs builds the documentation in docs/
```

Expand All @@ -100,13 +100,13 @@ This projects follows the following pattern for grouping imports in Go files:
* imports from standard library
* imports from other projects
* imports from `jaeger` project

For example:

```go
import (
"fmt"

"github.com/uber/jaeger-lib/metrics"
"go.uber.org/zap"

Expand Down
Loading

0 comments on commit 5f6af99

Please sign in to comment.