Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Renovatebot from upgrading major versions #5607

Closed
yurishkuro opened this issue Jun 12, 2024 · 1 comment · Fixed by #5613
Closed

Prevent Renovatebot from upgrading major versions #5607

yurishkuro opened this issue Jun 12, 2024 · 1 comment · Fixed by #5613
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jun 12, 2024

One immediate need: in this PR #5604 the bot is bumping Cassandra image versions 3 and 4 to 5, but we actually need them to stay where they are because they are part of the backwards compatibility testing in the CI. There has to be a way to instruct Renovatebot (via config) that we only want minor/patch version upgrades, either for specific docker compose files, or for specific image names.

Similar issue in #5605 and #5606

@DustyMMiller
Copy link
Contributor

I created a PR to fix this based on their docs. This is my first PR to a CNCF project so please let me know if I made any mistakes or need to do more with it.
Thanks

yurishkuro pushed a commit that referenced this issue Jun 13, 2024
)

## Which problem is this PR solving?
Updates #5607 to also turn off patches for the e2e test dependencies

## Description of the changes
Adds "patch" to the matchUpdateTypes array so that Renovatebot will not
automate PRs for patches on the e2e test dependencies

## How was this change tested?
Tested in fork and verified it wouldn't apply patches for those
specified docker-compose files.

## Checklist
- [ x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ n/a] I have added unit tests for the new functionality
- [ n/a] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: Dusty Miller <dusty.miller109@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants