Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Badger storage to v4 #5611

Closed
yurishkuro opened this issue Jun 12, 2024 · 1 comment · Fixed by #5619
Closed

Upgrade Badger storage to v4 #5611

yurishkuro opened this issue Jun 12, 2024 · 1 comment · Fixed by #5619
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jun 12, 2024 •
edited

Renovate bot created this PR #5610, but it's not really doing anything since we'd also need to change the imports:

$ grx badger/v3 plugin/storage/badger
plugin/storage/badger/spanstore/rw_internal_test.go:23:	"github.com/dgraph-io/badger/v3"
plugin/storage/badger/spanstore/cache_test.go:20:	"github.com/dgraph-io/badger/v3"
plugin/storage/badger/spanstore/cache.go:22:	"github.com/dgraph-io/badger/v3"
plugin/storage/badger/spanstore/writer.go:24:	"github.com/dgraph-io/badger/v3"
plugin/storage/badger/spanstore/reader.go:27:	"github.com/dgraph-io/badger/v3"
plugin/storage/badger/factory.go:27:	"github.com/dgraph-io/badger/v3"
plugin/storage/badger/samplingstore/storage_test.go:22:	"github.com/dgraph-io/badger/v3"
plugin/storage/badger/samplingstore/storage.go:23:	"github.com/dgraph-io/badger/v3"

They may be compatibility issues both in the APIs and with the data. In particular, we will need to verify that data created with the current version can still be used with v4.
@yurishkuro yurishkuro added enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement labels Jun 12, 2024
@yurishkuro yurishkuro mentioned this issue Jun 12, 2024
Closed
1 task
@hellspawn679
Copy link
Contributor

hellspawn679 commented Jun 13, 2024 •
edited

i would like to work on this issue

@hellspawn679 hellspawn679 mentioned this issue Jun 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Badger v3->Badger v4 hellspawn679/jaeger
2 participants
@yurishkuro @hellspawn679