-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Badger v3->Badger v4 #5619
Conversation
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5619 +/- ##
==========================================
- Coverage 96.20% 96.19% -0.02%
==========================================
Files 327 327
Lines 16014 16014
==========================================
- Hits 15406 15404 -2
- Misses 432 433 +1
- Partials 176 177 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please see testing requirements in the issue. |
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
did you do the backwards compatibility test as described in the issue? |
how can I do that? Is there a make command that I can use to check it? |
no, there's not. You'd need:
|
steps taken :-
mkdir tmp && cd tmp && mkdir key && mkdir span
export SPAN_STORAGE_TYPE=badger
export BADGER_EPHEMERAL=false
export BADGER_CONSISTENCY=true
export BADGER_DIRECTORY_KEY=/home/kali/go/new/jaeger/tmp/key
export BADGER_DIRECTORY_VALUE=/home/kali/go/new/jaeger/tmp/span
cd ..
make run-all-in-one
go run ./examples/hotrod/main.go all
git checkout badger
make run-all-in-one |
that's an awesome log of testing! |
Signed-off-by: mehul gautam <mehulsharma4786@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test