Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop testing tchannel in crossdock #783

Closed
6 of 7 tasks
yurishkuro opened this issue Apr 23, 2018 · 1 comment
Closed
6 of 7 tasks

Stop testing tchannel in crossdock #783

yurishkuro opened this issue Apr 23, 2018 · 1 comment
Labels
meta-issue An tracking issue that requires work in other repos

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Apr 23, 2018 •
edited by pavolloffay
Loading

The tchannel repos already have OpenTracing crossdock tests. Having them in Jaeger repos as well is legacy code, and it creates unnecessary conflicts, eg in the Go client we are stuck with the old version of thrift, the Node client is not able to run the full test matrix, etc.

Plan to remove tchannel from crossdock is:

  • remove it from all docker-compose files first
  • remove code from the driver
  • remove code from clients
    • go
    • java
    • node
    • python
This was referenced Apr 24, 2018
Merged
Merged
Merged
Merged
Merged
Merged
@yurishkuro yurishkuro added the meta-issue An tracking issue that requires work in other repos label May 31, 2018
@pavolloffay
Copy link
Member

It seems it have been fixed in all linked repositories. I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta-issue An tracking issue that requires work in other repos
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yurishkuro @pavolloffay