Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Remove tchannel as tested transport in crossdock #403

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

yurishkuro
Copy link
Member

Per jaegertracing/jaeger#783

Signed-off-by: Yuri Shkuro ys@uber.com

Signed-off-by: Yuri Shkuro <ys@uber.com>
@ghost ghost assigned yurishkuro Apr 24, 2018
@ghost ghost added the review label Apr 24, 2018
@codecov
Copy link

codecov bot commented Apr 24, 2018

Codecov Report

Merging #403 into master will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #403      +/-   ##
===========================================
+ Coverage     84.25%   84.5%   +0.24%     
- Complexity      500     501       +1     
===========================================
  Files            66      66              
  Lines          2033    2033              
  Branches        247     247              
===========================================
+ Hits           1713    1718       +5     
+ Misses          239     235       -4     
+ Partials         81      80       -1
Impacted Files Coverage Δ Complexity Δ
...aegertracing/samplers/RemoteControlledSampler.java 85.85% <0%> (+1.01%) 20% <0%> (+1%) ⬆️
...ava/io/jaegertracing/reporters/RemoteReporter.java 87.05% <0%> (+2.35%) 8% <0%> (ø) ⬇️
...in/java/io/jaegertracing/senders/ThriftSender.java 79.54% <0%> (+4.54%) 10% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09177f4...bb3045d. Read the comment docs.

Copy link
Contributor

@isaachier isaachier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yurishkuro yurishkuro merged commit a14169d into master Apr 24, 2018
@yurishkuro yurishkuro deleted the remove-tchannel-xdock-tests branch April 24, 2018 18:21
@ghost ghost removed the review label Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants