Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more information for timeout #1171

Merged

Conversation

clyang82
Copy link
Contributor

Signed-off-by: Chun Lin Yang clyang@cn.ibm.com

To address the review comment in #1139 (comment)

Signed-off-by: Chun Lin Yang <clyang@cn.ibm.com>
@clyang82
Copy link
Contributor Author

/ @yurishkuro

@codecov
Copy link

codecov bot commented Nov 13, 2018

Codecov Report

Merging #1171 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1171   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         144     144           
  Lines        6839    6839           
======================================
  Hits         6839    6839
Impacted Files Coverage Δ
plugin/storage/cassandra/options.go 100% <100%> (ø) ⬆️
plugin/storage/es/options.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bcba5...ea9eed7. Read the comment docs.

@yurishkuro yurishkuro merged commit e708ff9 into jaegertracing:master Nov 13, 2018
@yurishkuro
Copy link
Member

thanks!

@yurishkuro
Copy link
Member

PS consider commenting on #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants