-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Zipkin Protobuf spans over HTTP #1695
Conversation
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned by importing zipkin-go that brings with it dependencies on protobuf with potentially conflicting versions. Why can't we just use the zipkin proto file and generate the model ourselves? As far as I can tell there is no dependency on any other logic from zipkin-go.
@yurishkuro Thanks! You have a fair point about us having to control which proto version we want to support. I can update this PR to use proto file directly and generate code, and jaeger-idl looks like ideal place to put this proto file. |
Yes, the proto file can go to jaeger-idl |
Have a look at xdock tests, there are already tests for zipkin thrift and v2 json. We could leverage the same approach and add proto. It will require adding support for proto reporter in https://github.com/jaegertracing/xdock-zipkin-brave |
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1695 +/- ##
========================================
Coverage ? 98.3%
========================================
Files ? 194
Lines ? 9521
Branches ? 0
========================================
Hits ? 9360
Misses ? 126
Partials ? 35
Continue to review full report at Codecov.
|
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
I missed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also enable the xdock tests here?
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
@pavolloffay thanks! Added them now. I think we should merge jaegertracing/xdock-zipkin-brave#13 to go forward with this main PR. |
@jan25 I have added there one comment, otherwise it looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like crossdock failed on the new test (as well as on e2e test, but that one could be a bit flaky)
otherwise lgtm
return tSpan, nil | ||
} | ||
|
||
func traceIDFromBytes(tid []byte) (model.TraceID, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps incorporate this into func (t *TraceID) Unmarshal(data []byte) error
instead. In which case the *BytesLen
constants can remain private
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
thanks @jan25 |
Thanks for all the help! @yurishkuro I was working on your comment in the review :) but this is already merged, will open different PR when i have that refactored. |
I have considered it as fixed due to 👍 mark on the comment. thanks @jan25 |
@jan25 are you using Jaeger in booking.com? If yes could you please add an entry to https://github.com/jaegertracing/jaeger/blob/master/ADOPTERS.md or at least comment in #207 |
@pavolloffay Not yet, But noted the links from your previous comment to update them when booking.com does :) thanks! |
thanks @jan25 ! |
Which problem is this PR solving?
/api/v2/spans
Short description of the changes
Temporarily marking this PR as WIP. Please review/suggest on the implementation