Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose option to enable TLS when sniffing an Elasticsearch Cluster #2263

Merged
merged 2 commits into from
Jun 12, 2020
Merged

Expose option to enable TLS when sniffing an Elasticsearch Cluster #2263

merged 2 commits into from
Jun 12, 2020

Commits on May 28, 2020

  1. Expose option to enable TLS when sniffing an Elasticsearch Cluster 

    Jaeger uses the default scheme set by the olivere client (which is http) when sniffing an Elasticsearch cluster without the option to change it.  This makes it impossible to use sniffing with a TLS Elasticsearch cluster.

The scheme can be set using SetScheme client option
https://pkg.go.dev/github.com/olivere/elatic/v7\?tab\=doc\#SetScheme

This change exposes that client option as a boolean command line option: --es.sniffer-tls-enabled

Signed-off-by: nilsenj <jennynilsen@rentalcars.com>
    @jennynilsen
    jennynilsen committed May 28, 2020
    Configuration menu
    Copy the full SHA
    9e4669f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. Removing default options and correcting lint failures 

    Signed-off-by: nilsenj <jennynilsen@rentalcars.com>
    @jennynilsen
    jennynilsen committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    a298a3f View commit details
    Browse the repository at this point in the history