-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OTLP receiver listen on all IPs again #5739
Conversation
Signed-off-by: Yuri Shkuro <github@ysh.us>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5739 +/- ##
=======================================
Coverage 96.84% 96.84%
=======================================
Files 335 335
Lines 16155 16166 +11
=======================================
+ Hits 15645 15656 +11
Misses 340 340
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing the listening challenges.
Which problem is this PR solving?
Description of the changes
:port
instead of relying on OTEL Collector defaultsHow was this change tested?
COLLECTOR_OTLP_HTTP_HOST_PORT=:4318