coverage while upgrading linter #5975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anishbista60
requested review from
joe-elliott
and removed request for
a team
dosubot
bot
added
area/storage
storage/badger
yurishkuro
reviewed
Sep 11, 2024
yurishkuro
added
the
changelog:ci
anishbista60
force-pushed
the
dependabot/go_modules/internal/tools/github.com/golangci/golangci-lint-1.61.0
branch
from
6a079ff
to
bbf5f43
Compare
|
@yurishkuro Done. Works fine in my machine. |
yurishkuro
reviewed
Sep 13, 2024
yurishkuro
reviewed
Sep 13, 2024
yurishkuro
reviewed
Sep 13, 2024
anishbista60
force-pushed
the
dependabot/go_modules/internal/tools/github.com/golangci/golangci-lint-1.61.0
branch
from
bbf5f43
to
7ea26d3
Compare
|
@yurishkuro done |
Signed-off-by: Anish Bista <anishbista053@gmail.com>
anishbista60
force-pushed
the
dependabot/go_modules/internal/tools/github.com/golangci/golangci-lint-1.61.0
branch
from
7ea26d3
to
a4d4be8
Compare
yurishkuro
merged commit 5b3955e
into
jaegertracing:dependabot/go_modules/internal/tools/github.com/golangci/golangci-lint-1.61.0
3 checks passed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
fixes #5974
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test