Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Decouple storage factory creation and initialization #6272

Closed
wants to merge 13 commits into from

fix

9d6920a
Select commit
Loading
Failed to load commit list.
Closed

[refactor] Decouple storage factory creation and initialization #6272

fix
9d6920a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 29, 2024 in 0s

48.87% (target 95.00%)

View this Pull Request on Codecov

48.87% (target 95.00%)

Details

Codecov Report

Attention: Patch coverage is 64.61538% with 69 lines in your changes missing coverage. Please review.

Project coverage is 48.87%. Comparing base (76593a6) to head (9d6920a).

Files with missing lines Patch % Lines
plugin/storage/es/factory.go 48.57% 18 Missing ⚠️
plugin/storage/factory.go 65.95% 13 Missing and 3 partials ⚠️
pkg/telemetry/settings.go 37.50% 9 Missing and 1 partial ⚠️
...eger/internal/extension/jaegerstorage/extension.go 0.00% 7 Missing ⚠️
plugin/storage/cassandra/factory.go 84.44% 7 Missing ⚠️
plugin/storage/blackhole/factory.go 0.00% 4 Missing ⚠️
plugin/storage/badger/factory.go 75.00% 3 Missing ⚠️
plugin/storage/grpc/factory.go 83.33% 2 Missing ⚠️
plugin/storage/memory/factory.go 75.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (76593a6) and HEAD (9d6920a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (76593a6) HEAD (9d6920a)
unittests 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #6272       +/-   ##
===========================================
- Coverage   96.41%   48.87%   -47.55%     
===========================================
  Files         355      179      -176     
  Lines       20152    10848     -9304     
===========================================
- Hits        19430     5302    -14128     
- Misses        532     5100     +4568     
- Partials      190      446      +256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov