Fix io error when extracing zip archive containing folders #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a binary is contained in a folder in a zip archive (i.e.
bin_path_in_archive
has a prefix), extracting will fail with an io error "No such file or directory", becausefs::File::create
inExtract::extract_into
andExtract::extract_path
is passed the path of the binary including the zipped parent folder, which does not exist yet.The commit adds tests for these cases and cleans up some existing tests.