Clean up dangling temporary directories on Windows #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting a docker rate limit error on one of the CI jobs, need to try again later. |
|
Tests passed now |
jaemk
reviewed
Feb 28, 2021
| let is_expected_tmp_file = |tmp_file_entry: std::io::Result<fs::DirEntry>| { | ||
| tmp_file_entry | ||
| .ok() | ||
| .filter(|e| e.file_name() == expected_tmp_filename) |
There was a problem hiding this comment.
do we care to check if the dir contains other subdirs (this is only checking the files in the dir, right?)?
There was a problem hiding this comment.
fs::read_dir returns subdirectories as well, so the cleanup fails if there are any (just double-checked now). self_update doesn't create any subdirectories in the temp directory because it's only used for replace_using_temp. If subdirectories exist then the user is using the temp directory for something else (not sure why that would be the case, but wanted to be careful with fs::remove_dir_all).
|
Nice, thanks @t-mw ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easiest solution I can think of to avoid temporary directories building up as discussed in #69. This creates a separate temporary directory just for the exe backup, which is manually removed on Windows the next time the updated exe is run. Could go in a patch release (last PR from me hopefully).
Backing up the exe to a separate temporary directory allows us to:
tempfilecrate now that it isn't used to store the exe backup.