feat: add bankplus

.github/pr_labeler.yml

@@ -13,3 +13,7 @@
 #   - x/*/client/**/*
 # "Type: ADR":
 #   - docs/architecture/**/*
+"C:x/foundation":
+  - x/foundation/**/*
+"C:x/bankplus":
+  - x/bankplus/**/*

.github/workflows/build.yml

@@ -43,6 +43,3 @@ jobs:
       - name: Build
         if: env.GIT_DIFF
         run: GOARCH=${{ matrix.go-arch }} make build
-      - name: Build Legacy
-        if: env.GIT_DIFF
-        run: GOARCH=${{ matrix.go-arch }} COSMOS_BUILD_OPTIONS=legacy make build

.github/workflows/proto.yml

@@ -28,4 +28,4 @@ jobs:
       - uses: bufbuild/buf-breaking-action@v1
         with:
           input: "proto"
-          against: "https://github.com/${{ github.repository }}.git#branch=${{ github.event.pull_request.base.ref }},ref=HEAD~1,subdir=proto"
+          against: "https://github.com/${{ github.repository }}.git#branch=${{ github.event.pull_request.base.ref }},subdir=proto"

.github/workflows/test.yml

@@ -113,40 +113,41 @@ jobs:
   #         name: "${{ github.sha }}-integration-coverage"
   #         path: ./tests/integration-profile.out
 
-  # test-e2e:
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - uses: actions/checkout@v3
-  #     - uses: actions/setup-go@v4
-  #       with:
-  #         go-version: "1.21"
-  #         check-latest: true
-  #         cache: true
-  #         cache-dependency-path: go.sum
-  #     - uses: technote-space/get-diff-action@v6.1.2
-  #       id: git_diff
-  #       with:
-  #         PATTERNS: |
-  #           **/*.go
-  #           go.mod
-  #           go.sum
-  #           **/go.mod
-  #           **/go.sum
-  #           **/Makefile
-  #           Makefile
-  #     - name: e2e tests
-  #       if: env.GIT_DIFF
-  #       run: |
-  #         make test-e2e-cov
-  #     - uses: actions/upload-artifact@v3
-  #       if: env.GIT_DIFF
-  #       with:
-  #         name: "${{ github.sha }}-e2e-coverage"
-  #         path: ./tests/e2e-profile.out
+  test-e2e:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
+        with:
+          go-version: "1.21"
+          check-latest: true
+          cache: true
+          cache-dependency-path: go.sum
+      - uses: technote-space/get-diff-action@v6.1.2
+        id: git_diff
+        with:
+          PATTERNS: |
+            **/*.go
+            go.mod
+            go.sum
+            **/go.mod
+            **/go.sum
+            **/Makefile
+            Makefile
+      - name: e2e tests
+        if: env.GIT_DIFF
+        run: |
+          make test-e2e-cov
+      - uses: actions/upload-artifact@v3
+        if: env.GIT_DIFF
+        with:
+          name: "${{ github.sha }}-e2e-coverage"
+          path: ./tests/e2e-profile.out
 
   repo-analysis:
     runs-on: ubuntu-latest
-    needs: [tests, test-integration, test-e2e]
+    # needs: [tests, test-integration, test-e2e]
+    needs: [ tests, test-e2e ]
     steps:
       - uses: actions/checkout@v3
       - uses: technote-space/get-diff-action@v6.1.2
@@ -178,11 +179,11 @@ jobs:
       #   if: env.GIT_DIFF
       #   with:
       #     name: "${{ github.sha }}-integration-coverage"
-      # - uses: actions/download-artifact@v3
-      #   if: env.GIT_DIFF
-      #   with:
-      #     name: "${{ github.sha }}-e2e-coverage"
-      #   continue-on-error: true
+      - uses: actions/download-artifact@v3
+        if: env.GIT_DIFF
+        with:
+          name: "${{ github.sha }}-e2e-coverage"
+        continue-on-error: true
       - name: sonarcloud
         if: ${{ env.GIT_DIFF && !github.event.pull_request.draft }}
         uses: SonarSource/sonarcloud-github-action@master
@@ -276,11 +277,6 @@ jobs:
         run: |
           cd simapp
           go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock rocksdb_build' ./...
-      - name: tests simapp v1
-        if: env.GIT_DIFF
-        run: |
-          cd simapp
-          go test -mod=readonly -timeout 30m -tags='app_v1 norace ledger test_ledger_mock rocksdb_build' ./...
       - name: sonarcloud
         if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
         uses: SonarSource/sonarcloud-github-action@master
@@ -296,3 +292,65 @@ jobs:
 
   # NOTE: The following jobs are used to test the Finschia SDK Go submodules present under x/{module}.
   # They run when there is a diff in their respective directories.
+
+  test-x-foundation:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
+        with:
+          go-version: "1.21"
+          check-latest: true
+          cache: true
+          cache-dependency-path: x/foundation/go.sum
+      - uses: technote-space/get-diff-action@v6.1.2
+        id: git_diff
+        with:
+          PATTERNS: |
+            x/foundation/**/*.go
+            x/foundation/go.mod
+            x/foundation/go.sum
+      - name: tests
+        if: env.GIT_DIFF
+        run: |
+          cd x/foundation
+          go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock rocksdb_build' ./...
+      - name: sonarcloud
+        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          projectBaseDir: x/foundation/
+
+  test-x-bankplus:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
+        with:
+          go-version: "1.21"
+          check-latest: true
+          cache: true
+          cache-dependency-path: x/bankplus/go.sum
+      - uses: technote-space/get-diff-action@v6.1.2
+        id: git_diff
+        with:
+          PATTERNS: |
+            x/bankplus/**/*.go
+            x/bankplus/go.mod
+            x/bankplus/go.sum
+      - name: tests
+        if: env.GIT_DIFF
+        run: |
+          cd x/bankplus
+          go test -mod=readonly -timeout 30m -coverprofile=coverage.out -covermode=atomic -tags='norace ledger test_ledger_mock rocksdb_build' ./...
+      - name: sonarcloud
+        if: ${{ env.GIT_DIFF && !github.event.pull_request.draft && env.SONAR_TOKEN != null }}
+        uses: SonarSource/sonarcloud-github-action@master
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+        with:
+          projectBaseDir: x/bankplus/

.golangci.yml

@@ -52,6 +52,10 @@ issues:
     - text: "SA1019: codec.NewAminoCodec is deprecated" # TODO remove once migration path is set out
       linters:
         - staticcheck
+    - path: "client/cli"  # TODO(@0Tech): remove after foundation exec proposal removed
+      text: "SA1019: govcli.FlagDescription is deprecated"
+      linters:
+        - staticcheck
     - text: "leading space"
       linters:
         - nolintlint

CHANGELOG.md

@@ -40,8 +40,12 @@ Ref: https://keepachangelog.com/en/1.0.0/
 ## [Unreleased](https://github.com/Finschia/finschia-sdk/compare/v0.48.0...HEAD)
 
 ### Features
+
+* (x/foundation) [\#1198](https://github.com/Finschia/finschia-sdk/pull/1198) update x/foundation to use
+  Finschia/cosmos-sdk
 * (all) [\#1205](https://github.com/Finschia/finschia-sdk/pull/1205) delegate native logics to Finschia/cosmos-sdk
 * (consensus) [\#1178](https://github.com/Finschia/finschia-sdk/pull/1178) change the consensus from Ostracon to Tendermint v0.34.24
+* (x/bankplus) [\#1223](https://github.com/Finschia/finschia-sdk/pull/1223) update x/bankplus to use Finschia/cosmos-sdk
 
 ### Improvements
 * (docs) [\#1120](https://github.com/Finschia/finschia-sdk/pull/1120) Update links in x/foundation README.md

api/go.mod

@@ -5,6 +5,7 @@ go 1.21
 toolchain go1.21.5
 
 require (
+	cosmossdk.io/api v0.7.2
 	github.com/cosmos/cosmos-proto v1.0.0-beta.3
 	github.com/cosmos/cosmos-sdk v0.50.2
 	github.com/cosmos/gogoproto v1.4.11
@@ -14,7 +15,6 @@ require (
 )
 
 require (
-	cosmossdk.io/api v0.7.2 // indirect
 	cosmossdk.io/collections v0.4.0 // indirect
 	cosmossdk.io/core v0.11.0 // indirect
 	cosmossdk.io/depinject v1.0.0-alpha.4 // indirect