Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate very long titles in the item presentation component (or enlarge header height) #25

Closed
blatinier opened this issue Mar 15, 2016 · 2 comments
Labels
bug It's a bug ! Preventing normal use should be treated in priority. minor
Milestone

Comments

@blatinier
Copy link

When the item has a very long title (97 chars on my screen for exemple) the icons in the header on the item presentation component (the one at the right) go out of the header.

A solution is to truncate the titles around 80 chars (which works for me but not for everyone I think)
Maybe some css magic can work here.

Another solution is to set the header to the right height which is not really pretty I think.

@jaesivsm
Copy link
Owner

I'd prefer not to truncate title because there is no other way to read it and certain feed provide most of their text through their title. The title could be repeated below but I feel it would seem uneasy on the eye.

I'd prefer the style solution (fixing icons on top or something similar).

@jaesivsm jaesivsm added bug It's a bug ! Preventing normal use should be treated in priority. minor labels Mar 15, 2016
@jaesivsm jaesivsm added this to the 1.0.1 - Divlyn milestone Mar 15, 2016
@blatinier
Copy link
Author

Some CSS like this seems to work for me:
<img width="16px" src="FEED-ICON" style="position: absolute; padding-top: 3px"> <span style="display: inline-block; width: 80%; padding-left: 20px;">LONG TITLE</span>

Explanations:
The buttons at the right need place → span width: 80% + display: inline-block so that width has effect (maybe using a div instead does the trick too)
After that the feed icon is not well placed. position: absolute make its position absolute to the parent block (so it doesn't get moved around by block magics) the padding-top center it on the line.
Finally the padding-left on the span leave space for the feed icon.

blatinier added a commit to blatinier/JARR that referenced this issue Mar 27, 2016
@jaesivsm jaesivsm modified the milestones: 1.0.1 - Divlyn, 1.0.2 - Madrid Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug ! Preventing normal use should be treated in priority. minor
Projects
None yet
Development

No branches or pull requests

2 participants