Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] InputMapper fail to map to correct action #144

Closed
mayanksuman opened this issue Aug 9, 2021 · 1 comment
Closed

[BUG] InputMapper fail to map to correct action #144

mayanksuman opened this issue Aug 9, 2021 · 1 comment
Labels
bug Something isn't working
Milestone
v1.0

Comments

@mayanksuman
Copy link
Contributor

mayanksuman commented Aug 9, 2021 •
edited
Loading

Description
When two different input sequences of same length and same end KeyEvent are defined then InputMapper fails to map to correct action.

To Reproduce
Define two input sequences as shown in this figure.

Screenshot from 2021-08-09 13-37-02

These two input sequences have two keyEvents with same last KeyEvent. First one is double click on Spotlight device and other one is Next Button Press followed by Click on Spotlight device.

Now try to press these two input sequences one by one, you will not be able to get right action in both cases.

For me, I always get 'b' Key Sequence.

Expected behavior
The InputMapper should map to correct action.
mayanksuman added a commit to mayanksuman/Projecteur that referenced this issue Aug 9, 2021
@mayanksuman
Fix InputMapper issue jahnf#144
d2d6214 
In case, when two different input sequence of same length and same end
KeyEvent are defined then InputMapper fails to map to correct action.

This commit fixes the issue with InputMapper. The correct action is
decided on the basis of all keys pressed (instead of last key pressed
in earlier version of code).
@mayanksuman mayanksuman mentioned this issue Aug 9, 2021
Closed
mayanksuman added a commit to mayanksuman/Projecteur that referenced this issue Aug 9, 2021
@mayanksuman
Fix InputMapper issue jahnf#144
5830bb9 
In case, when two different input sequence of same length and same end
KeyEvent are defined then InputMapper fails to map to correct action.

This commit fixes the issue with InputMapper. The correct action is
decided on the basis of all keys pressed (instead of last key pressed
in earlier version of code).
@jahnf jahnf mentioned this issue Aug 9, 2021
Merged
@jahnf
Copy link
Owner

jahnf commented Aug 9, 2021

Thank you mayank - good find - the way it was implemented by me with a map was producing the wrong output - basically overwriting any Action that was already set. This will be fixed with #146 .

@jahnf jahnf closed this as completed in 465eefd Aug 9, 2021
jahnf added a commit that referenced this issue Aug 9, 2021
@jahnf
Merge pull request #146 from jahnf/bugfix/144-input-mapping
50b20bd 
Fix input mapping. Fixes #144
@jahnf jahnf added the bug Something isn't working label Aug 9, 2021
@jahnf jahnf added this to the v1.0 milestone Aug 9, 2021
mayanksuman pushed a commit to mayanksuman/Projecteur that referenced this issue Aug 10, 2021
@jahnf @mayanksuman
Fix input mapping. Fixes jahnf#144
e2d7719
mayanksuman pushed a commit to mayanksuman/Projecteur that referenced this issue Aug 10, 2021
@jahnf @mayanksuman
Fix input mapping. Fixes jahnf#144
82ef574
jahnf added a commit that referenced this issue Sep 30, 2021
@jahnf
Fix input mapping. Fixes #144
595829e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Fix InputMapper issue with same sized Input Sequences mayanksuman/Projecteur
2 participants
@mayanksuman @jahnf