Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the configuration section explicit about all run modes #379

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Make the configuration section explicit about all run modes #379

merged 3 commits into from
Jun 6, 2022

Conversation

starksm64
Copy link
Contributor

Addresses #378

starksm64 and others added 2 commits June 3, 2022 14:45
…ly jboss-tck-runner example

Signed-off-by: Scott M Stark <starksm64@gmail.com>
Signed-off-by: Scott M Stark <starksm64@gmail.com>
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starksm64 starksm64 merged commit aba3d61 into jakartaee:master Jun 6, 2022
@manovotn
Copy link
Contributor

manovotn commented Jun 6, 2022

@Ladicek feel free to add any comments if you think this doesn't address it sufficiently.

@breakponchito
Copy link
Contributor

breakponchito commented Jun 6, 2022

I'm seeing that the config example for the Core profile is excluding the following: <excludedGroups>cdi-full,se</excludedGroups> While the text explaining the config say something different: You can configure the CDI TCK to just run tests related to the CDI Lite specification appropriate for the Jakarta EE Core Profile by excluding TestNG groups cdi-full, integration, javaee-full, se, e.g. via a maven-surefire-plugin configuration like Is this correct?

@starksm64
Copy link
Contributor Author

Yes, and the core profile TCK includes an appropriate TestNG suite file that already has this configured, so you could just run using the suite.xml without any excluded group specified:

https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/core-profile-tck/cdi-tck-suite/src/main/resources/cdi-lite-tck-suite.xml

@Ladicek
Copy link
Contributor

Ladicek commented Jun 9, 2022

I think @breakponchito highlights that there's an inconsistency between the text and the XML snippet. Which is fair I think, we should update the text.

<groups>se,arquillian</groups>
<dependenciesToScan>
<dependency>jakarta.enterprise:cdi-tck-core-impl</dependency>
</configuration>
Copy link
Contributor

@Emily-Jiang Emily-Jiang Jun 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This snippet misses one line to close the element:
</dependenciesToScan>
before the line 152
</configuration>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants