Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@PostConstruct method on interceptor SheepInterceptor should have InvocationContext parameter #449

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

manovotn
Copy link
Contributor

Fixes #448

@manovotn manovotn requested a review from Ladicek April 19, 2023 19:23
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception catching and rethrowing looks ugly and I personally think that declaring throws Exception would be fine, because the Interceptors spec makes a distinction between "declaring to throw checked exceptions" and "throwing checked exceptions", but it's not a big deal.

@Ladicek
Copy link
Contributor

Ladicek commented Apr 20, 2023

Since #448 is not a challenge, we can't merge this into 4.0 TCK I believe.

I also believe this would be a valid challenge, but I'll leave that to you to decide :-)

@manovotn
Copy link
Contributor Author

The exception catching and rethrowing looks ugly and I personally think that declaring throws Exception would be fine, because the Interceptors spec makes a distinction between "declaring to throw checked exceptions" and "throwing checked exceptions", but it's not a big deal.

It doesn't make a difference as the interceptor is meant not to be invoked in the first place 🤷

I also believe this would be a valid challenge, but I'll leave that to you to decide :-)

Fine, let's do it.

@Ladicek Ladicek merged commit e799036 into jakartaee:master Apr 20, 2023
@manovotn manovotn deleted the issue448 branch April 20, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post construct interceptor missing an invocation context parameter
2 participants