Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for both Java SE 17 and Java SE 21 in Concurrency 3.1 #414

Closed
3 tasks done
Tracked by #458
njr-11 opened this issue Jan 16, 2024 · 0 comments
Closed
3 tasks done
Tracked by #458

Support for both Java SE 17 and Java SE 21 in Concurrency 3.1 #414

njr-11 opened this issue Jan 16, 2024 · 0 comments
Milestone

Comments

@njr-11
Copy link
Contributor

njr-11 commented Jan 16, 2024

A change in direction was recently announced that Jakarta EE 11 specifications must be built against Java SE 17 or lower rather than Java SE 21 (the previous plan). This impacts our Concurrency 3.1 release and will require some changes.

  • API updates to support Java SE 17 #415 Update the Concurrency 3.1 API to remove usage Java SE 21. This will impact our API JavaDoc which currently links to directly into Java SE 21 API for virtual threads. We will need to get rid of those links to allow the project to be built against Java 17.
  • TCK tests for virtual threads #425 Change how we write TCK tests to carefully avoid use of Java SE 21 or do so reflectively. This will impact tests scenarios like verifying that the managed executors can capture context from a virtual thread and propagate it to a managed executor thread, or that the context service can propagate context when running inline on a virtual thread, as well as other tests that need to identify whether a virtual thread is used in order to make assertions. These tests will need to become aware of the Java SE level and then conditionally skip (if less than 21) or invoke Java SE 21 methods reflectively or some other mechanism that allows Java SE 21 to be used. This will make the test code difficult to understand, but this seems to be the only option.
  • Switch the project to compile against Java SE 17.
@njr-11 njr-11 added this to the 3.1 milestone Jan 16, 2024
njr-11 added a commit to njr-11/concurrency-api that referenced this issue Jan 16, 2024
Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
njr-11 added a commit to njr-11/concurrency-api that referenced this issue Feb 15, 2024
…=true there

Signed-off-by: Nathan Rauh <nathan.rauh@us.ibm.com>
@KyleAure KyleAure mentioned this issue Mar 18, 2024
19 tasks
@njr-11 njr-11 closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant