Add suite file for web and make tck/api versions clear #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An extra suite.xml file was added to the starter module to test the web-profile. The guide was updated to mention this. Since the API version of Concurrency (e.g. 3.0.1) and the TCK version (e.g. 3.0.2) don't necessarily have to be the same, the properties for these were renamed to make it more clear which is which. Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
OndroMih
approved these changes
Jul 28, 2022
KyleAure
approved these changes
Jul 28, 2022
| @@ -17,6 +17,9 @@ | |||
| --> | |||
| <!DOCTYPE suite SYSTEM "http://testng.org/testng-1.0.dtd" > | |||
|
|
|||
| <!-- | |||
| This suite file is for testing Jakarta Concurrency against the Jakarta Full Profile. | |||
| --> | |||
| <suite name="jakarta-concurrency" verbose="2" configfailurepolicy="continue"> | |||
| <test name="jakarta-concurrency.tck"> | |||
| <packages> | |||
There was a problem hiding this comment.
This file will also need to be updated to exclude the Web profile duplicated tests that I will be working on today. Otherwise, we will be adding tests to the Full profile run that were not there in the original release.
I will include that in my PR and It shouldn't hold up this one from being merged.
njr-11
approved these changes
Jul 28, 2022
|
Thanks, looking forward to the follow PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extra suite.xml file was added to the starter module to test the
web-profile. The guide was updated to mention this.
Since the API version of Concurrency (e.g. 3.0.1) and the TCK version
(e.g. 3.0.2) don't necessarily have to be the same, the properties for
these were renamed to make it more clear which is which.
Signed-off-by: Arjan Tijms arjan.tijms@gmail.com